GOATS-984 GOATS-986: Add workflow state to backend and frontend. #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement WorkflowStateSerializer for handling workflow state data. - Refactor GPPTooViewSet to include _format_workflow_state_properties method. - Update clone observation and target serializers to inherit from _BaseSerializer. - Modify frontend field identifiers with new workflow state handling. - Add disabled option for workflow state field in frontend. - Add tests for workflow state serialization and validation.
There was a problem hiding this comment.
Pull Request Overview
This PR implements workflow state handling for both backend and frontend, enabling users to view and select observation workflow states in the GPP observation form. The changes refactor serializers to use a shared base class for form data normalization and add comprehensive test coverage.
- Implements
WorkflowStateSerializerfor validating and converting workflow state selections - Refactors serializers to inherit from
_BaseSerializerfor consistent form data handling - Adds workflow state selection UI with disabled options for non-editable states
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/goats_tom/serializers/gpp/workflow_state.py | New serializer for workflow state validation and enum conversion |
| src/goats_tom/serializers/gpp/_base.py | Base serializer class extracting common form data normalization logic |
| src/goats_tom/serializers/gpp/clone_observation.py | Refactored to inherit from _BaseSerializer |
| src/goats_tom/serializers/gpp/clone_target.py | Refactored to inherit from _BaseSerializer |
| src/goats_tom/serializers/gpp/init.py | Updated exports to include WorkflowStateSerializer |
| src/goats_tom/api_views/gpp/toos.py | Moved _format_workflow_state_properties implementation to proper location |
| src/goats_tom/static/js/gpp/fields.js | Added workflow state field definition with option states |
| src/goats_tom/static/js/gpp/observation_form.js | Added support for disabled select options and removed debug logging |
| tests/goats_tom/serializers/gpp/test_workflow_state.py | Comprehensive tests for workflow state serialization |
| tests/goats_tom/serializers/gpp/test__base.py | Tests for base serializer form data normalization |
| tests/goats_tom/api_views/gpp/test_toos.py | Updated tests for workflow state formatting methods |
| tests/conftest.py | Removed extra blank line |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 78.70% 78.91% +0.21%
==========================================
Files 260 264 +4
Lines 8307 8390 +83
Branches 489 490 +1
==========================================
+ Hits 6538 6621 +83
Misses 1680 1680
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesusing the PR number.